feat: Min/max version for the tagline #5917
Merged
+93
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5917 +/- ##
==========================================
- Coverage 9.54% 6.59% -2.95%
==========================================
Files 325 436 +111
Lines 16411 24563 +8152
==========================================
+ Hits 1567 1621 +54
- Misses 14844 22942 +8098 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
teolemon
reviewed
Nov 24, 2024
| @@ -316,7 +316,7 @@ class UserPreferencesDevMode extends AbstractUserPreferences { | |||
| return Consumer<AppNewsProvider>( | |||
| builder: (_, AppNewsProvider provider, __) { | |||
| return Text(switch (provider.state) { | |||
| AppNewsStateLoading() => 'Loading...', | |||
| AppNewsStateLoading() => 'Loading…', | |||
There was a problem hiding this comment.
It's in the Dev mode, but yes, I can translate it
teolemon
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone!
The JSON can now provide a
min_versionand/or amax_versionfor each news item.Some examples:
max_version: a message to notify there's an update availablemin_versiononly ormin_version=max_version: changelog of new featuresBy version, it's not the version code, but the version name (e.g.:
1.2.3)In this PR, there's also a fix, where sometimes the Tagline is not visible (mainly at launch) and the DEV Mode status is not refreshing.